Nate Graham <> changed:

           What    |Removed                     |Added
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |
                   |                            |temsettings/6f5b6e41ec4dec6
                   |                            |af9693c3a22e5181ee850414b
   Version Fixed In|                            |KDE Plasma 5.12.2

--- Comment #9 from Nate Graham <> ---
Git commit 6f5b6e41ec4dec6af9693c3a22e5181ee850414b by Nathaniel Graham.
Committed on 19/02/2018 at 14:53.
Pushed by ngraham into branch 'Plasma/5.12'.

Improve sidebar header visibility

FIXED-IN: KDE Plasma 5.12.2

System Settings' sidebar headers were implemented as orginary Kirigami list
items that had `enabled: false` set, which made them turn an almost unreadable
light color. This a hack; it should have used real headers. And it was the
wrong hack, as evidenced by the visual breakage.

This patch changes the hack to a different one that works much better. Ideally
we would use real Kirigami list headers here, but the current system settings
implementation seems to make this a challenge and I'm not sure it's worth it.
Willing to be proven wrong, though.

Test Plan:
Before, primary category headers, Breeze light:

After, primary category headers, Breeze light:

Before, sub-category headers, Breeze light:

After, sub-category headers, Breeze light:

Before, primary category headers, Breeze dark:

After, primary category headers, Breeze dark:

Before, sub-category headers, Breeze dark:

After, sub-category headers, Breeze dark:

Reviewers: #plasma, #kirigami, mart

Reviewed By: #plasma, #kirigami, mart

Subscribers: rkflx, plasma-devel

Tags: #plasma, #kirigami

Differential Revision:

M  +1    -1    sidebar/package/contents/ui/CategoriesPage.qml
M  +0    -1    sidebar/package/contents/ui/SubCategoryPage.qml

You are receiving this mail because:
You are watching all bug changes.

Reply via email to