--- Comment #32 from Thanh Trung Dinh <dinhthanhtrung1...@gmail.com> ---
About your first point that WelcomePageViewPage class should be deleted, that
was right since we can access by QWebEngineView::page(). However, I found that
the class was created in order to overload method
QWebEnginePage::acceptNavigationRequest(const QUrl &, NavigationType , bool ),
so that when a link on the welcome page is clicked, it will open a browser for
that link. Since QWebEngineView doesn't support any signal to capture an event
linkClicked as QWebView did, overloading that method is the best way to work
around. Besides, if we don't open link in another browser, I don't know how to
return to welcome page except closing and reopening application.
So, I guess we should keep that class?
You are receiving this mail because:
You are watching all bug changes.