https://bugs.kde.org/show_bug.cgi?id=390737

--- Comment #13 from Henrik Fehlauer <rk...@lab12.net> ---
The bug you linked is probably unrelated, and I doubt changes in Qt 5.11 will
help in our case (I only know about https://phabricator.kde.org/D5109#162592).

IMO it's quite unrealistic to expect you to fix KIconLoader if even more
experienced developers are stuck (see https://phabricator.kde.org/D6313). Also,
https://phabricator.kde.org/D10532 clearly applied a similar fix and it was
allowed to go in.

Looking at the "Open With" dialog you get for "Add Program", you'll observe the
problem with QIcon::fromTheme we've talked about elsewhere (which I believe
should possibly be fixed in Breeze): Going from 1x scaling to 1.5x scaling, the
Akregator icon changes colour. Now, given for this dialog it's somewhat broken,
I'd suggest to just go with QIcon::fromTheme for your patch too.

Let me know where you are stuck, or upload a WIP version. I tried it myself,
and the patch really is not all that complicated. Just try to understand what
the code is doing in both cases, and you should be able to adapt it.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to