https://bugs.kde.org/show_bug.cgi?id=390148

Nate Graham <n...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
      Latest Commit|https://commits.kde.org/dis |https://commits.kde.org/dis
                   |cover/2b9e1b5e1ebbfab384b3f |cover/b623a4afb12f0bfa74f76
                   |e3febe63e0ef076c273         |711598e84772a1c6d2f
         Resolution|---                         |FIXED

--- Comment #11 from Nate Graham <n...@kde.org> ---
Git commit b623a4afb12f0bfa74f76711598e84772a1c6d2f by Nathaniel Graham.
Committed on 06/03/2018 at 12:28.
Pushed by ngraham into branch 'master'.

Fix the Add Source dialog

Summary:
Fix a variety of bugs and usability issues with the {nav Add Source} dialog:
- Make the close button actually close the dialog
- Give the text field focus so you can immediately start typing
- Make the return key push the Add button
- Remove needless close symbol in top-right corner
- Give the buttons icons
- Re-word the title and make it larger

Test Plan:
Before:
{F5738465}

After:
{F5738429}

Tested with Flatpak backend:
- Invalid URLs are rejected
- Valid URLs that nonetheless don't point to a Flatpak repo trigger an error
message
- The close button now closes the dialog
- The escape key still closes the dialog
- The return and enter keys press the {nav Add} button

Reviewers: #discover_software_store, apol

Reviewed By: #discover_software_store, apol

Subscribers: acrouthamel, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D11003

M  +22   -20   discover/qml/AddSourceDialog.qml

https://commits.kde.org/discover/b623a4afb12f0bfa74f76711598e84772a1c6d2f

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to