https://bugs.kde.org/show_bug.cgi?id=392026
Nate Graham <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Latest Commit| |https://commits.kde.org/pla | |sma-framework/3a66e9a0a5ea8 | |dc792d4a2bafbfce3c81b73ebed Resolution|--- |FIXED Status|CONFIRMED |RESOLVED --- Comment #3 from Nate Graham <[email protected]> --- Git commit 3a66e9a0a5ea8dc792d4a2bafbfce3c81b73ebed by Nathaniel Graham. Committed on 19/03/2018 at 15:40. Pushed by ngraham into branch 'master'. Fix combobox breakage Summary: https://cgit.kde.org/plasma-framework.git/commit/?id=a21bc11fe11651f6d211489ebfc8435cef877194 erroneously added `renderType` properties to PlasmaComponents3 ComboBoxes, but QML ComboBoxes don't have this property, which broke Latte Dock's settings. This patch removes it. Test Plan: - Deployed, added Latte Dock, ran Plasmashell with and without `PLASMA_USE_QT_SCALING=1`, and with and without a HiDPI scale factor - Opened Latte Dock's settings window. In all cases, Latte Dock's settings window appeared normally and all comboboxes rendered properly - Opened Folder View settings and verified that all ComboBoxes there looked and worked fine, too Reviewers: broulik, #plasma, mvourlakos, davidedmundson Reviewed By: #plasma, davidedmundson Subscribers: #frameworks Tags: #frameworks Differential Revision: https://phabricator.kde.org/D11484 M +0 -4 src/declarativeimports/plasmacomponents3/ComboBox.qml M +0 -4 src/declarativeimports/plasmastyle/ComboBoxStyle.qml https://commits.kde.org/plasma-framework/3a66e9a0a5ea8dc792d4a2bafbfce3c81b73ebed -- You are receiving this mail because: You are watching all bug changes.
