https://bugs.kde.org/show_bug.cgi?id=387444
David Edmundson <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|CONFIRMED |RESOLVED Latest Commit| |https://commits.kde.org/pla | |sma-desktop/db311474f0486d5 | |cfcef069663e53be37d764cf2 --- Comment #1 from David Edmundson <[email protected]> --- Git commit db311474f0486d5cfcef069663e53be37d764cf2 by David Edmundson. Committed on 22/03/2018 at 08:51. Pushed by davidedmundson into branch 'master'. Fix use of assert/crash when removing global shortcut Summary: I'm not the author, but it's pretty clear what the intention was. We expect to get one result back from proxyModel->match We use results.first(), so we want to check we have at least one entry. The assert was written backwards Test Plan: Can now remove a group without a crash Reviewers: #plasma, graesslin Reviewed By: #plasma, graesslin Subscribers: graesslin, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D11567 M +1 -1 kcms/keys/kglobalshortcutseditor.cpp https://commits.kde.org/plasma-desktop/db311474f0486d5cfcef069663e53be37d764cf2 -- You are receiving this mail because: You are watching all bug changes.
