https://bugs.kde.org/show_bug.cgi?id=374913
Alex Richardson <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Latest Commit|https://commits.kde.org/pla |https://commits.kde.org/pla |sma-integration/bfd41a95530 |sma-integration/cc064e81c6e |f90ee8d44cbcfd1fa8c62978334 |d51f3b4422c2f2347e5f4e090e6 |a2 |28 --- Comment #23 from Alex Richardson <[email protected]> --- Git commit cc064e81c6ed51f3b4422c2f2347e5f4e090e628 by Alex Richardson. Committed on 08/04/2018 at 14:05. Pushed by arichardson into branch 'Plasma/5.12'. KDEPlatformFileDialog: Fix initial directory selection for remote files Summary: Previously KDEPlatformFileDialogHelper::selectFile() would change options()->initialDirectory() unconditionally even if it was already set by the QFileDialog code. Since Qt 5.7.1 it is no longer necessary to derive initialDirectory from the selectFile() call. In fact it is actuall harmful since it will now override the correct initial directory that was set by Qt. Without this patch I got the following debug output: ``` KDEPlatformFileDialogHelper::setDirectory QUrl("sftp://server/home/alr48/cheri/build_sdk.sh";) KDEPlatformFileDialogHelper::setDirectory QUrl("sftp://server/home/alr48/cheri/build_sdk.sh";) KDEPlatformFileDialogHelper::selectFile QUrl("file:///home/alex/build_sdk.sh") KDEPlatformFileDialogHelper::setDirectory QUrl("file:///home/alex/) ``` The final setDirectory() call is actually a call to `setDirectory(options->initialDirectory())` which was set in `selectFile()`. We now depend on Qt 5.9 so we can remove this code without a check for version >= 5.7.1. Test Plan: Remote directory is now opened correctly (tested with Qt 5.10.0) Reviewers: #plasma, elvisangelaccio Reviewed By: elvisangelaccio Subscribers: ngraham, krzyc, anthonyfieroni, elvisangelaccio, graesslin, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D4193 M +0 -5 src/platformtheme/kdeplatformfiledialoghelper.cpp https://commits.kde.org/plasma-integration/cc064e81c6ed51f3b4422c2f2347e5f4e090e628 -- You are receiving this mail because: You are watching all bug changes.
