https://bugs.kde.org/show_bug.cgi?id=392620

Stefan Brüns <stefan.bru...@rwth-aachen.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/bal
                   |                            |oo/116e55a2076e5dd3264be4ad
                   |                            |8a06b6a2554b6fda
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #2 from Stefan Brüns <stefan.bru...@rwth-aachen.de> ---
Git commit 116e55a2076e5dd3264be4ad8a06b6a2554b6fda by Stefan Brüns.
Committed on 08/04/2018 at 15:41.
Pushed by bruns into branch 'master'.

Handle adjacent special characters correctly

Summary:
The code handled sequences like '((' incorrectly, i.e. this was parsed as
a single opening quote, and thus could get operator association wrong.
Although only '>=' and '<=' have a special meaning, also accept '==' and
':=' as '=' resp. ':'.

Test Plan:
```
38: QDEBUG : AdvancedQueryParserTest::testNestedParentheses(a OR ((b AND c) AND
d))   result term [ OR ( : a (QString)) [ AND ( : b (QString)) ( : c (QString))
( : d (QString)) ] ]
38: QDEBUG : AdvancedQueryParserTest::testNestedParentheses(a OR ((b AND c) AND
d)) expected term [ OR ( : a (QString)) [ AND ( : b (QString)) ( : c (QString))
( : d (QString)) ] ]
38: PASS   : AdvancedQueryParserTest::testNestedParentheses(a OR ((b AND c) AND
d))

```

Reviewers: #baloo, michaelh

Reviewed By: #baloo, michaelh

Subscribers: #frameworks

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D11888

M  +1    -1    autotests/unit/lib/advancedqueryparsertest.cpp
M  +28   -39   src/lib/advancedqueryparser.cpp

https://commits.kde.org/baloo/116e55a2076e5dd3264be4ad8a06b6a2554b6fda

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to