Valeriy Malov <> changed:

           What    |Removed                     |Added
         Resolution|---                         |FIXED
      Latest Commit|                            |
                   |                            |omtablet/ba954d21575bb74f27
                   |                            |24bf582e66817f8d9391f4
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #1 from Valeriy Malov <> ---
Git commit ba954d21575bb74f2724bf582e66817f8d9391f4 by Valeriy Malov.
Committed on 15/04/2018 at 18:00.
Pushed by valeriymalov into branch 'master'.

Get button mapping from libwacom

Grab evdev codes from libwacom and convert them into xsetwacom button
Requires libwacom 0.29
Add a crude "test" that compares local database data with libwacom data

This should make libwacom a suitable substitute for local database,
excluding status led info and button layout picture

Test Plan:
Hard to test this without pad buttons so a code review would suffice

I've slapped together a crude "test tool" that compares data pulled from
libwacom and data pulled from local installed database
Mostly it seems to match, ignoring the button order (I don't think we care
about button order, since button order can be subjective when user is filling
it out using tablet finder)
Where it doesn't match it probably needs to be checked individually via google
or feedback from device owner
Here's the output for the test tool if anyone's curious:

Reviewers: fvogt

Differential Revision:

M  +5    -0    CMakeLists.txt
M  +1    -0    autotests/CMakeLists.txt
A  +8    -0    autotests/common/libwacomdata/CMakeLists.txt
A  +142  -0    autotests/common/libwacomdata/testlibwacomdata.cpp     [License:
GPL (v2+)]
M  +7    -5    cmake/modules/FindLibWacom.cmake
M  +92   -5    src/common/libwacomwrapper.cpp

You are receiving this mail because:
You are watching all bug changes.

Reply via email to