https://bugs.kde.org/show_bug.cgi?id=394272
David Edmundson <k...@davidedmundson.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
Latest Commit| |https://commits.kde.org/kru
| |nner/56382f8d9a80796a21d708
| |7ddb660519fbbb5c2e
--- Comment #3 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 56382f8d9a80796a21d7087ddb660519fbbb5c2e by David Edmundson.
Committed on 16/05/2018 at 09:21.
Pushed by davidedmundson into branch 'master'.
Process DBus replies in the ::match thread
Summary:
6114612970bcf757d9e06a623d6220257ce57b5f turned the DBus requests into
using QDBusPendingCallWatcher but blocking so that it's still handled
within the ::match() method. However, it accidentally processed replies
in the main thread, rather than in the match thread which wasn't the
intention.
Result is occasional threading related crashes.
Test Plan:
Still had results from baloo (one of our DBus runners)
It didn't crash (but it never crashed for me before either)
One tester replied:
[10:00] <sunnyflunk> d_ed: looks good, tried 30 times with patch and no
crash, then turned off the patch and crashed 4th time
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D12924
M +1 -1 src/dbusrunner.cpp
https://commits.kde.org/krunner/56382f8d9a80796a21d7087ddb660519fbbb5c2e
--
You are receiving this mail because:
You are watching all bug changes.
