https://bugs.kde.org/show_bug.cgi?id=360020
Jan Kundrát <j...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Latest Commit| |http://commits.kde.org/troj
| |ita/6a65385a96221a285c9fe9e
| |52d70bf5541071c36
Resolution|--- |FIXED
--- Comment #28 from Jan Kundrát <j...@kde.org> ---
Git commit 53ddfe7ebfe235ec8b0cf5823c81bbe41cda143c by Jan Kundrát.
Committed on 07/03/2016 at 14:32.
Pushed by gerrit into branch 'master'.
Use synthetic CSS for specifying colors of the "web" content
The usual story -- if the current color theme is dark and the QWebView
is showing an HTML message, Bad Stuff™ happens quite easily.
By going through a custom CSS stylesheet, we achieve more or less
consistent results as far as I can see -- including various HTML e-mails
that I have in my test collection. There are of course also e-mails
where it goes horribly wrong, so the real question is "should we try to
emulate dark theme on HTML content, or should we always use white
background in order to "better accommodate all content"?
Thomas was kind enough to add a heuristic which tries to arrive to font
colors which are usable on both dark and bright backgrounds, but as
usually -- it's just a heuristic, and it will break on certain inputs.
The alternative is to always and unconditionally force black-on-white. I
could do that pretty easily.
Change-Id: Iabdf9b0d97448b070fa7aa1ca4302cc6b2c8b77f
M +27 -0 src/Gui/EmbeddedWebView.cpp
M +1 -0 src/Gui/EmbeddedWebView.h
M +1 -4 src/Gui/SimplePartWidget.cpp
http://commits.kde.org/trojita/53ddfe7ebfe235ec8b0cf5823c81bbe41cda143c
--- Comment #29 from Jan Kundrát <j...@kde.org> ---
Git commit 6a65385a96221a285c9fe9e52d70bf5541071c36 by Jan Kundrát.
Committed on 07/03/2016 at 14:59.
Pushed by gerrit into branch 'master'.
HTML: Support selecting custom color schemes
...because one cannot please everybody, so let's add a funny button for
this. Oh well.
Change-Id: I51b380df4c93fb4e6eef175aaed99eaf742f8cba
M +54 -16 src/Gui/EmbeddedWebView.cpp
M +15 -0 src/Gui/EmbeddedWebView.h
M +14 -0 src/Gui/SimplePartWidget.cpp
http://commits.kde.org/trojita/6a65385a96221a285c9fe9e52d70bf5541071c36
--
You are receiving this mail because:
You are watching all bug changes.
