https://bugs.kde.org/show_bug.cgi?id=382324

Vlad Zagorodniy <vladz...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/pla
                   |                            |sma-framework/dce258bee3da8
                   |                            |54980b6f2430b26f7025752a505
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #13 from Vlad Zagorodniy <vladz...@gmail.com> ---
Git commit dce258bee3da854980b6f2430b26f7025752a505 by Vlad Zagorodniy.
Committed on 06/06/2018 at 17:52.
Pushed by vladz into branch 'master'.

FrameSvg: Recache maskFrame if enabledBorders has been changed

Summary:
In some cases, when rendering frame svg background, measures & margins
do not correspond to `enabledBorders`. I.e. `bottomHeight` may be equal to 5,
but the bottom border is disabled. This causes visual artifacts like this

{F5878318, layout=center, size=full}

//Pay close attention to the bottom of the Task switcher. It has a transparent
strip at the bottom, which shouldn't be there.//

The cause of this problem is that FrameSVGPrivate::alphaMask doesn't take
enabledBorders
into account when it's making decision whether it should update maskFrame.

Just for reference, this is "after"

{F5878319, layout=center, size=full}
Related: bug 390632, bug 391659

Test Plan:
* Triggered the Breeze task switcher (with compositing on and off)
* Didn't see any transparent strips

---

* Tried running FrameSvgTest, still passes

Reviewers: #plasma, #frameworks, mart

Reviewed By: #plasma, mart

Subscribers: abetts, mart, aseigo, broulik, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D13215

M  +16   -10   src/plasma/framesvg.cpp

https://commits.kde.org/plasma-framework/dce258bee3da854980b6f2430b26f7025752a505

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to