https://bugs.kde.org/show_bug.cgi?id=395651

--- Comment #7 from Chris <chrisret...@gmx.com> ---
(In reply to David Edmundson from comment #6)
> set(SomeVariable)
> 
> is not creating something hardcoded, rather the exact opposite. It's
> creating a variable that can be set from outside with a default.
> 
> i.e
> cmake -DMOZILLA_DIR=/tmp/cheese  or set with ccmake/cmake-gui 
> 
> 
> (it's irrelevant to the point about whether the default should be lib or
> lib64, but quite important to clarify)

It is creating something hard coded. 

set(MOZILLA_DIR "${CMAKE_INSTALL_PREFIX}/lib/mozilla" CACHE STRING "Mozilla
directory")

'/lib/mozilla' IS hard coded. So if CMAKE_INSTALL_PREFIX=/usr then
MOZILLA_DIR becomes '/usr/lib/mozilla'

I am proposing to make use of KDE_INSTALL_LIBDIR to set from the outside. So
that MOZILLA_DIR can be set to /usr/lib64/mozilla or /usr/lib/mozilla or
/usr/<value>/mozilla

set(MOZILLA_DIR "${CMAKE_INSTALL_PREFIX}${KDE_INSTALL_LIBDIR}/mozilla" CACHE
STRING "Mozilla directory")

cmake -DCMAKE_INSTALL_PREFIX=/usr -DKDE_INSTALL_LIBDIR=/lib64

results in MOZILLA_DIR set to '/usr/lib64/mozilla'

KDE_INSTALL_LIBDIR could also be CMAKE_INSTALL_LIBDIR

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to