https://bugs.kde.org/show_bug.cgi?id=395627

Michael Pyne <mp...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |https://commits.kde.org/kde
                   |                            |src-build/7f92da7b307c784de
                   |                            |ec804f65137b10733e6a88e
         Resolution|---                         |FIXED
   Version Fixed In|                            |18.08

--- Comment #4 from Michael Pyne <mp...@kde.org> ---
Git commit 7f92da7b307c784deec804f65137b10733e6a88e by Michael Pyne.
Committed on 01/07/2018 at 23:15.
Pushed by mpyne into branch 'master'.

Don't double-set CMAKE_PREFIX_PATH if set by user.

This fixes bug 395627, where the error is actually that we set
CMAKE_PREFIX_PATH twice if qtdir is set to a non-system path and the
user is also setting CMAKE_PREFIX_PATH.

Unfortunately the second value overrides the first (the one the user
set).

Also added a test for this, which fails before the fix and passes
afterwards. The full test suite (all 5...) pass.
FIXED-IN:18.08

M  +5    -2    modules/ksb/BuildSystem/KDE4.pm
A  +78   -0    t/bug-395627-keep-cmake-prefix.t
A  +26   -0    t/data/bug-395627/kdesrc-buildrc

https://commits.kde.org/kdesrc-build/7f92da7b307c784deec804f65137b10733e6a88e

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to