https://bugs.kde.org/show_bug.cgi?id=397650

--- Comment #2 from Wolfgang Reissenberger <wreis...@gmx.de> ---
I would also prefer replacing seqTotalCount by activeJob->getCount(), since
caching the value always bears the risk that the value is not up to date. By
the way, seqTotalCount is no longer used, only present in capture.h.

The algorithm and its state for shooting flats is currently quite spread over
the entire class, which is already a huge one. As a first step I would
recommend encapsulating it inside capture.cpp. In a future step, it might make
more sense having a class FlatSequenceJob derived from SequenceJob holding all
the specifics for the different types of images.

As a hotfix, I would replace 
  if (activeJob->isPreview()) 
by
  if (activeJob->getCount() <= 0)

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to