https://bugs.kde.org/show_bug.cgi?id=359251
--- Comment #6 from Vlad Zagorodniy <[email protected]> --- Git commit 5165ee45b5e3448f46490edfe9326375ffa91a29 by Vlad Zagorodniy. Committed on 21/08/2018 at 08:50. Pushed by vladz into branch 'master'. [effects] Rewrite the Dim Inactive effect Summary: The Dim Inactive effect was rewritten mostly to fix most of issues with it, e.g. after leaving a full screen effect(e.g. Desktop Grid) windows sometimes are not dimmed back, or when a window becomes inactive there is no smooth transition, etc. {F5956124} //Before: the window is not smoothly dimmed.// {F5956127} //After: the window is smoothly dimmed.// In combination with an effect that animates the disappearing of windows, e.g. Glide, the rewritten Dim Inactive effect doesn't "flash" windows. If an active window has been closed, it will stay bright. If an inactive window has been closed, it will stay dimmed. Among other changes, the KCM has been re-designed to follow common KCM design in Plasma: {F5956128, layout=center, size=full} The way the rewritten Dim Inactive effect handles flashing/flickering problem can be reused in the Dialog Parent effect. ### Demo {F5959885} //Before: dimming of a window group.// {F5959886} //After: Dimming of a window group.// Depends on D13740 Test Plan: Test plan #1 * Activated the Desktop Grid effect * Dimmed windows smoothly brightened * Left desktop grid * Windows dimmed back Test plan #2 * Opened Dolphin and its Preferences window * Clicked on desktop, both Dolphin and the Preferences window dimmed * Clicked on Dolphin, both windows smoothly brightened back Reviewers: #kwin, #plasma, #vdg, davidedmundson Reviewed By: #kwin, #plasma, #vdg, davidedmundson Subscribers: davidedmundson, abetts, ngraham, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D13720 M +329 -81 effects/diminactive/diminactive.cpp M +91 -48 effects/diminactive/diminactive.h M +11 -20 effects/diminactive/diminactive_config.cpp M +8 -12 effects/diminactive/diminactive_config.h M +39 -107 effects/diminactive/diminactive_config.ui https://commits.kde.org/kwin/5165ee45b5e3448f46490edfe9326375ffa91a29 -- You are receiving this mail because: You are watching all bug changes.
