https://bugs.kde.org/show_bug.cgi?id=397809
Dmitry Kazakov <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|CONFIRMED |RESOLVED Latest Commit| |https://commits.kde.org/kri | |ta/b1744c79888fbeb384d3ce76 | |d2b0db637ddce95a --- Comment #3 from Dmitry Kazakov <[email protected]> --- Git commit b1744c79888fbeb384d3ce76d2b0db637ddce95a by Dmitry Kazakov. Committed on 28/08/2018 at 11:02. Pushed by dkazakov into branch 'master'. Fix a crash when undo/redo a creation of a selection mask There were several architectural fixes needed: 1) KisAnimationCurveChannelListModel stores an internal list of selected nodes (dummies), therefore it should also be subscribed to sigBeginRemoveDummy() signal to update this list **before** the dummy will be actually deleted. 2) KisNodeManager should not allow activating a node if it is not visible in the layers docker (KisNodeModel). To move the "model" part of node hiding into KisNodeManager without making all the internal classes depend on it a special class KisNodeDisplayModeAdapter was introduced. M +3 -2 libs/libqml/plugins/kritasketchplugin/models/LayerModel.cpp M +1 -0 libs/ui/CMakeLists.txt A +76 -0 libs/ui/KisNodeDisplayModeAdapter.cpp [License: GPL (v2+)] A +51 -0 libs/ui/KisNodeDisplayModeAdapter.h [License: GPL (v2+)] M +1 -1 libs/ui/kis_node_filter_proxy_model.cpp M +16 -0 libs/ui/kis_node_manager.cpp M +2 -0 libs/ui/kis_node_manager.h M +32 -15 libs/ui/kis_node_model.cpp M +5 -2 libs/ui/kis_node_model.h M +2 -2 libs/ui/tests/kis_model_index_converter_test.cpp M +5 -5 libs/ui/tests/kis_node_model_test.cpp M +1 -1 libs/ui/tests/kis_node_view_test.cpp M +25 -1 plugins/dockers/animation/kis_animation_curve_channel_list_model.cpp M +4 -0 plugins/dockers/animation/kis_animation_curve_channel_list_model.h M +3 -2 plugins/dockers/defaultdockers/kis_layer_box.cpp https://commits.kde.org/krita/b1744c79888fbeb384d3ce76d2b0db637ddce95a -- You are receiving this mail because: You are watching all bug changes.
