https://bugs.kde.org/show_bug.cgi?id=398790
Bug ID: 398790
Summary: Kdevelop/Sublime : D15450 causes crash in patch review
toolview
Product: kdevelop
Version: 5.2.80
Platform: Compiled Sources
OS: All
Status: REPORTED
Severity: crash
Priority: NOR
Component: general
Assignee: [email protected]
Reporter: [email protected]
Target Milestone: ---
Created attachment 115066
--> https://bugs.kde.org/attachment.cgi?id=115066&action=edit
backtrace
- What I was doing when the application crashed:
Opened the patch review plugin. This causes a systematic crash because of a
floating point exception.
Reason: another good example of inappropriate ASSERT usage. The exception
occurs when _items.size() == smallItemCount, and it is assumed that this must
always be the case.
It is however evident that the list of layout items could very well contain
only small items, and it is also evident how to handle that situation. Only
small items => no shrinkage needed.
So the proper implementation doesn't use a Q_ASSERT but does
if (_items.size() != smallItemCount) {
// evenly distribute surplus height over large items
shrinkedHeight = maximumHeight + surplus / (_items.size() -
smallItemCount);
} else {
// Only small items, no shrinkage needed
shrink = false;
}
--
You are receiving this mail because:
You are watching all bug changes.
