https://bugs.kde.org/show_bug.cgi?id=317496
David Edmundson <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #3 from David Edmundson <[email protected]> --- >* The data type “sig_atomic_t” should be used for the variable >“wake_up_socket”. Technically yes (or std::atomic if we want to be modern), though practically we're not not using that variable in parallel in the main thread except in cleanup. I'd happily accept a patch, or I can do it. >* Is the data processing for “SIGHUP” still questionable? Doesn't seem to do anything useful, it was there since the initial commit. I guess the author probably intended to do something. Using SIGHUP for config reloading isn't something we do in any KDE apps. -- You are receiving this mail because: You are watching all bug changes.
