https://bugs.kde.org/show_bug.cgi?id=365222
Boudewijn Rempt <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Latest Commit| |https://commits.kde.org/kri | |ta/5f91230f074be53379ba1461 | |c6a1560d1f8aa1eb Resolution|--- |FIXED Status|CONFIRMED |RESOLVED --- Comment #23 from Boudewijn Rempt <[email protected]> --- Git commit 5f91230f074be53379ba1461c6a1560d1f8aa1eb by Boudewijn Rempt. Committed on 29/11/2018 at 13:24. Pushed by rempt into branch 'master'. add a createActions method to KoToolFactoryBase Actions created by a tool instance only exist if there's an open document, which means they cannot be configured or placed in toolbars. We should only have per-window actions, not per-action actions. Creating the actions in the toolfactory instead of the tool when the window is created fixes that: now the tools will retrieve the actions from the global action collection on activations and de-activation, like the freehand tool already did for increase and decrease brush size. Note: this commit breaks the following tools because it's not worth porting hidden tools in any case: * artistic text tool * odf text tool * connection tool CMAIL:[email protected] M +0 -12 krita/kritamenu.action M +0 -3 libs/flake/KoCanvasController.cpp M +3 -3 libs/flake/KoCanvasController.h M +2 -58 libs/flake/KoToolBase.cpp M +0 -19 libs/flake/KoToolBase.h M +0 -1 libs/flake/KoToolBase_p.h M +94 -3 libs/flake/KoToolFactoryBase.cpp M +22 -0 libs/flake/KoToolFactoryBase.h M +84 -121 libs/flake/KoToolManager.cpp M +0 -3 libs/flake/KoToolManager.h M +49 -59 libs/flake/tools/KoPathTool.cpp M +2 -1 libs/flake/tools/KoPathTool.h M +22 -0 libs/flake/tools/KoPathToolFactory.cpp M +1 -0 libs/flake/tools/KoPathToolFactory.h M +3 -1 libs/ui/CMakeLists.txt M +21 -19 libs/ui/KisMainWindow.cpp M +1 -5 libs/ui/KisPart.cpp A +64 -0 libs/ui/tool/KisSelectionToolFactoryBase.cpp [License: LGPL (v2+)] A +44 -0 libs/ui/tool/KisSelectionToolFactoryBase.h [License: LGPL (v2+)] A +54 -0 libs/ui/tool/KisToolPaintFactoryBase.cpp [License: LGPL (v2+)] A +35 -0 libs/ui/tool/KisToolPaintFactoryBase.h [License: LGPL (v2+)] M +0 -17 libs/ui/tool/kis_tool_paint.cc M +0 -3 libs/ui/tool/kis_tool_polyline_base.cpp M +9 -33 libs/ui/tool/kis_tool_select_base.h M +4 -3 libs/ui/tool/kis_tool_shape.h M +2 -1 libs/widgetutils/kis_action_registry.cpp M +1 -1 libs/widgetutils/kis_action_registry.h M +3 -3 libs/widgetutils/xmlgui/kactionconflictdetector.cpp M +2 -2 plugins/assistants/Assistants/kis_assistant_tool.cc M +11 -11 plugins/flake/artistictextshape/ArtisticTextTool.cpp M +57 -57 plugins/flake/textshape/TextTool.cpp M +40 -36 plugins/tools/basictools/kis_tool_brush.cc M +18 -16 plugins/tools/basictools/kis_tool_brush.h M +3 -4 plugins/tools/basictools/kis_tool_ellipse.h M +3 -3 plugins/tools/basictools/kis_tool_fill.h M +3 -3 plugins/tools/basictools/kis_tool_gradient.h M +82 -45 plugins/tools/basictools/kis_tool_move.cc M +8 -7 plugins/tools/basictools/kis_tool_move.h M +1 -1 plugins/tools/basictools/kis_tool_multihand.cpp M +2 -3 plugins/tools/basictools/kis_tool_multihand.h M +3 -3 plugins/tools/basictools/kis_tool_rectangle.h M +15 -15 plugins/tools/defaulttool/connectionTool/ConnectionTool.cpp M +86 -73 plugins/tools/defaulttool/defaulttool/DefaultTool.cpp M +6 -0 plugins/tools/defaulttool/defaulttool/DefaultTool.h M +47 -0 plugins/tools/defaulttool/defaulttool/DefaultToolFactory.cpp M +2 -0 plugins/tools/defaulttool/defaulttool/DefaultToolFactory.h M +25 -0 plugins/tools/defaulttool/referenceimagestool/ToolReferenceImages.cpp M +5 -2 plugins/tools/defaulttool/referenceimagestool/ToolReferenceImages.h M +1 -0 plugins/tools/karbonplugins/tools/CMakeLists.txt A +46 -0 plugins/tools/karbonplugins/tools/CalligraphyTool/KarbonCalligraphyTool.action M +41 -37 plugins/tools/karbonplugins/tools/CalligraphyTool/KarbonCalligraphyTool.cpp M +4 -0 plugins/tools/karbonplugins/tools/CalligraphyTool/KarbonCalligraphyTool.h M +14 -0 plugins/tools/karbonplugins/tools/CalligraphyTool/KarbonCalligraphyToolFactory.cpp M +2 -0 plugins/tools/karbonplugins/tools/CalligraphyTool/KarbonCalligraphyToolFactory.h M +2 -3 plugins/tools/tool_dyna/kis_tool_dyna.cpp M +4 -7 plugins/tools/tool_dyna/kis_tool_dyna.h M +3 -3 plugins/tools/tool_lazybrush/kis_tool_lazy_brush.h M +2 -2 plugins/tools/tool_polygon/kis_tool_polygon.h M +2 -2 plugins/tools/tool_polyline/kis_tool_polyline.h M +3 -3 plugins/tools/tool_smart_patch/kis_tool_smart_patch.h https://commits.kde.org/krita/5f91230f074be53379ba1461c6a1560d1f8aa1eb -- You are receiving this mail because: You are watching all bug changes.
