https://bugs.kde.org/show_bug.cgi?id=392989

Matthieu Gallien <matthieu_gall...@yahoo.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/eli
                   |                            |sa/5847d0e03f5ef3bfad0ae8e5
                   |                            |00c5640122983edb
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
   Version Fixed In|                            |elisa  0.3.80

--- Comment #6 from Matthieu Gallien <matthieu_gall...@yahoo.fr> ---
Git commit 5847d0e03f5ef3bfad0ae8e500c5640122983edb by Matthieu Gallien, on
behalf of Ashwin Dhakaita.
Committed on 15/01/2019 at 16:23.
Pushed by mgallien into branch 'master'.

Global shortcut for play/pause action using spacebar key

Summary:
Assign SpaceBar key as the global shortcut for play/pause action.  Most of the
media player out there already use spacebar as the global shortcut for
play/pause action.  So,  it would be good to do the same for Elisa.
Modified ElisaMainWindow.qml to add the shortcut component.
Modified MediaPlayerControl.qml to prevent elements from getting focus as it
causes interference with the shortcut keypressed events.
FIXED-IN:    elisa  0.3.80

Reviewers: #elisa, ngraham, mgallien

Reviewed By: #elisa, ngraham, mgallien

Subscribers: shubham, mgallien, ngraham

Tags: #elisa

Differential Revision: https://phabricator.kde.org/D17994

M  +30   -0    src/elisaapplication.cpp
M  +6    -0    src/elisaapplication.h
M  +6    -0    src/qml/ElisaMainWindow.qml
M  +4    -0    src/qml/FlatButtonWithToolTip.qml
M  +19   -4    src/qml/MediaPlayListView.qml
M  +13   -1    src/qml/MediaPlayerControl.qml
M  +10   -0    src/qml/NavigationActionBar.qml

https://commits.kde.org/elisa/5847d0e03f5ef3bfad0ae8e500c5640122983edb

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to