https://bugs.kde.org/show_bug.cgi?id=399380
Nate Graham <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REPORTED |RESOLVED Resolution|--- |FIXED Latest Commit| |https://commits.kde.org/kio | |/c063b1ce848987c9d236d6ec3d | |9cf4f8c5f11627 --- Comment #3 from Nate Graham <[email protected]> --- Git commit c063b1ce848987c9d236d6ec3d9cf4f8c5f11627 by Nate Graham, on behalf of Denis Karpovskiy. Committed on 21/02/2019 at 20:16. Pushed by ngraham into branch 'master'. Add support for portals in KRun Summary: Currently KRun in Flatpak/Snap doesn't support portals so it can't launch an application for a given url (because it can't break through sandbox). This patch allows KRun to use portals to pass the url through sandbox. QDesktopServices::openUrl handles that case and sends appropriate DBus calls to portals, so URIs will be proccessed accordingly by host system. Test Plan: I couldn't build KIO from master in current flatpak KDE runtime (even without the patch), so here are commands to test the patch on top of KIO 5.54.1: 1. Install org.kde.Sdk 5.12 from flathub 2. Install org.kde.konversation from KDE Nightly flatpak repo (https://community.kde.org/Guidelines_and_HOWTOs/Flatpak) 3. Apply the patch to KIO 5.54.1 4. run 'flatpak run --filesystem=host --command=sh --devel org.kde.Sdk//5.12' to enter SDK 5. build KIO 6. exit SDK (exit or Ctrl+D) 7. run flatpak shell with Konversation 'flatpak run --filesystem=host --command=sh org.kde.konversation' 8. run LD_PRELOAD="path/to/libKF5KIOCore.so path/top/libKF5KIOWidgets.so path/to/libKF5KIOFileWidgets.so" /app/bin/konversation to run it with just compiled KIO (the compiled libraries are located in bin directory inside your build directory) Now link clicks should pass sandbox and do the appropriate actions (open browser for http links, email application for mailto links, file manager for file://...) Reviewers: jgrulich, apol, dfaure, #frameworks Reviewed By: apol Subscribers: ngraham, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D18762 M +18 -3 src/widgets/krun.cpp M +2 -0 src/widgets/krun_p.h https://commits.kde.org/kio/c063b1ce848987c9d236d6ec3d9cf4f8c5f11627 -- You are receiving this mail because: You are watching all bug changes.
