https://bugs.kde.org/show_bug.cgi?id=404407
Krešimir Čohar <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|ASSIGNED |RESOLVED Version Fixed In| |5.15.3 Latest Commit| |https://commits.kde.org/pla | |sma-workspace/23f3345a22878 | |eadc58a54eed27ad9a231877bca --- Comment #2 from Krešimir Čohar <[email protected]> --- Git commit 23f3345a22878eadc58a54eed27ad9a231877bca by Krešimir Čohar. Committed on 09/03/2019 at 16:12. Pushed by chopete into branch 'Plasma/5.15'. [notifications] Lift up notification content if one line of body text droops Summary: This patch lifts up the text content of notifications in which the combination of a single line of body text and its heading are taller than their icon and thereby prevents the notification content from drooping too far down and having too much of a bottom margin if it should become much larger than the icon. Seeing as the icon and its margins are never going to be taller than the content in question and the icon is always going to have 1 units.smallSpacing above it, this patch adjusts the height accordingly (0.5 units of smallSpacing above + 0.5 for the spacing below the heading + 0.5 below the content, accommodating the text) to achieve more even padding. This patch should also improve padding with fonts greater than 10 pt in size. FIXED-IN: 5.15.3 Test Plan: Before (left) and after (right): {F6616780} Reviewers: #plasma, #vdg, broulik, ngraham, filipf Reviewed By: #vdg, ngraham, filipf Subscribers: cfeck, anthonyfieroni, filipf, ngraham, abetts, broulik, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D19036 M +15 -3 applets/notifications/package/contents/ui/NotificationItem.qml https://commits.kde.org/plasma-workspace/23f3345a22878eadc58a54eed27ad9a231877bca -- You are receiving this mail because: You are watching all bug changes.
