https://bugs.kde.org/show_bug.cgi?id=403902
Alexander Stippich <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Latest Commit| |https://commits.kde.org/kfi | |lemetadata/649555ee31820af0 | |1869c7bfe8c1e96e5a9abb37 Resolution|--- |FIXED Status|CONFIRMED |RESOLVED --- Comment #12 from Alexander Stippich <[email protected]> --- Git commit 649555ee31820af01869c7bfe8c1e96e5a9abb37 by Alexander Stippich. Committed on 10/03/2019 at 15:02. Pushed by astippich into branch 'master'. Rewrite the taglib extractor to use the generic PropertyMap interface Summary: Rewrite the taglib extractor to use taglib's PropertyMap. Since this largely unifies the handling of the different tag formats, but not quite, a lot of code is removed. The resulting code is also faster. Additionally, this avoids the usage of a FileRef object, which fixes a potential crash due to a known bug in taglib. Test Plan: all tests pass Reviewers: ngraham, bruns, mgallien Reviewed By: bruns Subscribers: smithjd, kde-frameworks-devel, #baloo Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D18826 M +0 -2 autotests/taglibextractortest.cpp M +273 -880 src/extractors/taglibextractor.cpp M +6 -40 src/extractors/taglibextractor.h https://commits.kde.org/kfilemetadata/649555ee31820af01869c7bfe8c1e96e5a9abb37 -- You are receiving this mail because: You are watching all bug changes.
