https://bugs.kde.org/show_bug.cgi?id=405158
Kurt Hindenburg <kurt.hindenb...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/kon
| |sole/cb49c985a31692806be5f8
| |f717d79b1425cfcbc9
Status|ASSIGNED |RESOLVED
--- Comment #2 from Kurt Hindenburg <kurt.hindenb...@gmail.com> ---
Git commit cb49c985a31692806be5f8f717d79b1425cfcbc9 by Kurt Hindenburg, on
behalf of David Hallas.
Committed on 14/03/2019 at 03:01.
Pushed by hindenburg into branch 'master'.
Fixes crash when using the Copy Input To All Tabs feature
Summary:
Fixes crash when using the Copy Input To All Tabs feature. The crash is
caused because the sessions are removed from the SessionManager before
the MainWindow is updated. When the MainWindow receives the
activeViewChanged signal it assumes that the
SessionManager::sessionProfile returns a valid Profile pointer, but in
this case it has already been freed and is therefore nullptr. The fix is
to simply check if the new active Session has a valid Profile, if not
simply ignore it.
Test Plan:
1. Open Konsole window
2. Open multiple tabs within that Konsole window
3. (apparently an important piece) Scroll through the tabs and go back to the
first one opened, on the far left of the tab bar
4. Select Edit menu -> Copy Input To -> All Tabs in Current Window
5. Type a ctrl-D to issue logout command to all tabs in window
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: hindenburg, konsole-devel
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D19642
M +3 -0 src/MainWindow.cpp
https://commits.kde.org/konsole/cb49c985a31692806be5f8f717d79b1425cfcbc9
--
You are receiving this mail because:
You are watching all bug changes.
