https://bugs.kde.org/show_bug.cgi?id=390856

Nate Graham <n...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |19.04.0
      Latest Commit|                            |https://commits.kde.org/spe
                   |                            |ctacle/431ea89f51ae79ca0686
                   |                            |617d29a3129f130a1fb2
         Resolution|---                         |FIXED
             Status|REPORTED                    |RESOLVED

--- Comment #2 from Nate Graham <n...@kde.org> ---
Git commit 431ea89f51ae79ca0686617d29a3129f130a1fb2 by Nate Graham, on behalf
of David Redondo.
Committed on 14/03/2019 at 17:33.
Pushed by ngraham into branch 'master'.

Make the filename placeholders clickable

Summary:
This allows the user to click the placeholders. First step to improve the
filename template configuration. I also moved the available placeholders to the
ExportManager. The SaveOptionsPage doesn't need to care about which options are
present and we have to change them in only one class if we want to make
changes.
Further steps I plan to do are displaying a preview, improving the Layout (we
had to increase the size already) and eventually using better placeholders.
FIXED-IN: 19.04.0

Test Plan:
- Click on placeholder
- It appears in the LineEdit

Reviewers: #spectacle, ngraham

Reviewed By: #spectacle, ngraham

Subscribers: ngraham

Tags: #spectacle

Differential Revision: https://phabricator.kde.org/D19755

M  +13   -0    src/ExportManager.cpp
M  +3    -0    src/ExportManager.h
M  +13   -24   src/Gui/SettingsDialog/SaveOptionsPage.cpp

https://commits.kde.org/spectacle/431ea89f51ae79ca0686617d29a3129f130a1fb2

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to