https://bugs.kde.org/show_bug.cgi?id=405430
--- Comment #3 from Petar Jovanovic <[email protected]> --- (In reply to Mark Wielaard from comment #0) > I would like to enable -Wimplicit-fallthrough=2 by default when available. > It was introduced in GCC7. It caught a couple of bugs, but it does need a > bit of extra comments to explain when a switch case statement fall-through > is deliberate. Luckily with -Wimplicit-fallthrough=2 various existing > comments already do that. I have fixed the bugs, but adding explicit break > statements where necessary and added comments where the fall-through was > correct. > > There is just one place that produces a warning for a fallthrough that I am > not sure is deliberate or not. > > priv/guest_mips_toIR.c: In function ‘disInstr_MIPS_WRK’: > priv/guest_mips_toIR.c:30205:13: warning: this statement may fall through > [-Wimplicit-fallthrough=] > if (VEX_MIPS_COMP_ID(archinfo->hwcaps) == VEX_PRID_COMP_CAVIUM) { > ^ > priv/guest_mips_toIR.c:30211:7: note: here > case 0xC: /* INSV */ > ^~~~ This fallthrough is deliberate. I have made a comment in the git log to state this. Otherwise, changes in MIPS files look good to me. Thanks. -- You are receiving this mail because: You are watching all bug changes.
