https://bugs.kde.org/show_bug.cgi?id=395981

Dmitry Kazakov <dimul...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/kri
                   |                            |ta/759ecacbacdf1a6f62880604
                   |                            |a51bdf52ea46f4ab

--- Comment #8 from Dmitry Kazakov <dimul...@gmail.com> ---
Git commit 759ecacbacdf1a6f62880604a51bdf52ea46f4ab by Dmitry Kazakov.
Committed on 02/04/2019 at 16:42.
Pushed by dkazakov into branch 'master'.

Fix activation of Isolate Mode when merging the layers down

When merging layers down, a null layer is activated for a short
period of time. It happens because the following:

1) When we remove the top layer, LayerBox adjusts the currently
selected index to the lower node. And tries to activate it.

2) The activated node is passed further by the signals chain,
and then in KisNodeManager::slotNonUiActivatedNode() we find
out that this node has also been removed from the node graph.
Therefore we pass 0 to the lower-level code.

3) Isolate mode code sees that there is no layer selected and
stops the isolated mode.

The patch fixes the issue by storing a separate flag, marking
marking the presence of isolated mode. Even when there is no
layer to isolate, we still save the sate and try to activate
it when a valid node comes.

M  +7    -1    libs/ui/kis_node_manager.cpp

https://commits.kde.org/krita/759ecacbacdf1a6f62880604a51bdf52ea46f4ab

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to