https://bugs.kde.org/show_bug.cgi?id=183429
Elvis Angelaccio <elvis.angelac...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Version Fixed In| |19.08.0
Status|CONFIRMED |RESOLVED
Latest Commit| |https://commits.kde.org/dol
| |phin/27e3907a3daf9a63d05c00
| |a0ff746de6cfdf2bdf
--- Comment #32 from Elvis Angelaccio <elvis.angelac...@kde.org> ---
Git commit 27e3907a3daf9a63d05c00a0ff746de6cfdf2bdf by Elvis Angelaccio, on
behalf of Alexander Saoutkin.
Committed on 30/05/2019 at 20:40.
Pushed by elvisangelaccio into branch 'master'.
Open externally called files/directories in new tabs
Summary:
FIXED-IN: 19.08.0
GUI: new cli argument --new-window
Externally called files/directories are opened in a a new tab of an instance of
Dolphin that already exists. If any of the given URIs are already open in a
tab, then those tabs are activated instead of a new tab being opened. If there
is no instance then the files/directories are opened in a new window. The newly
opened file/directory has its tab activated, and consequently, the window is
also activated.
When the user clicks "Open In New Window" or "Detach Tab", the
files/directories are opened in a new window.
Test Plan:
[Manual]
Before testing, set the default file manager in system settings as the newly
built Dolphin executable.
One must also include the new dolphin executable in the $PATH, otherwise some
functions will attempt to open the system dolphin instead of the new one.
Furthermore, running two different versions of Dolphin (in particular, where
one does not have this patch included) can result in bugs appearing, in
particular, new tabs not opening as old instances will not recognise the DBus
commands sent to it. However, I see no reason why a user will have two
different versions of Dolphin (apart from people like us :D).
Open directories with the help of auxillary programs (i.e. a browser). The
files/directories should appear in a new window if an instance does not exist.
If an existence already exists, then a new tab should be opened and activated
in that instance and the window activated.
Use QDBusViewer to open folders/items by calling the ShowFolders/ShowItems
methods in org.freedesktop.FileManager1 of the Dolphin instance.
When a user chooses to "Open In New Window"/"Detach Tab" then the
files/directories should be opened in a new window.
Reviewers: #dolphin, elvisangelaccio
Subscribers: zzag, dfaure, fvogt, fikrim, magar, fbg13, davidedmundson, kwin,
ngraham, elvisangelaccio, anthonyfieroni, kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D16648
M +1 -0 CMakeLists.txt
M +1 -0 src/CMakeLists.txt
M +11 -2 src/dbusinterface.cpp
M +27 -0 src/dolphinmainwindow.cpp
M +33 -0 src/dolphinmainwindow.h
M +22 -2 src/dolphintabwidget.cpp
M +6 -0 src/dolphintabwidget.h
M +82 -2 src/global.cpp
M +6 -0 src/global.h
M +18 -5 src/main.cpp
https://commits.kde.org/dolphin/27e3907a3daf9a63d05c00a0ff746de6cfdf2bdf
--
You are receiving this mail because:
You are watching all bug changes.
