https://bugs.kde.org/show_bug.cgi?id=234153
David Edmundson <k...@davidedmundson.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Latest Commit| |https://commits.kde.org/kwi | |n/3604aaf74cac587757b20daea | |108f80ade9973d5 --- Comment #18 from David Edmundson <k...@davidedmundson.co.uk> --- Git commit 3604aaf74cac587757b20daea108f80ade9973d5 by David Edmundson. Committed on 23/06/2019 at 16:00. Pushed by davidedmundson into branch 'master'. Close screen grabbing effect when screensaver starts Summary: The screenlock fails on X11 if it can't grab the keyboard. We can't nicely solve the generic case. We can solve the common case of a kwin effect being active. It's not critical, arguably not even desirable to have these effects persist after the screen is locked through an external trigger. We can just close the effect early. Key grabs have to be relased early before the close animation completes so that the locker doesn't have a race based on animation times. It's not ideal, but no worse than the current state for not much work. Test Plan: locked screen on a timer opened various effects Reviewers: #kwin, zzag Reviewed By: #kwin, zzag Subscribers: ngraham, zzag, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D20890 M +1 -0 CMakeLists.txt M +1 -0 effects.cpp M +10 -0 effects/cube/cube.cpp M +8 -0 effects/desktopgrid/desktopgrid.cpp M +4 -0 effects/flipswitch/flipswitch.cpp M +3 -0 effects/presentwindows/presentwindows.cpp M +7 -0 libkwineffects/kwineffects.h M +7 -2 screenlockerwatcher.cpp M +4 -1 screenlockerwatcher.h https://commits.kde.org/kwin/3604aaf74cac587757b20daea108f80ade9973d5 -- You are receiving this mail because: You are watching all bug changes.