https://bugs.kde.org/show_bug.cgi?id=378904

Zeno Endemann <zeno.endem...@googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zeno.endem...@googlemail.co
                   |                            |m

--- Comment #4 from Zeno Endemann <zeno.endem...@googlemail.com> ---
I've recently run into this problem as well. So I've looked at the Ark sources,
but I don't see a good way to add this feature, both from the coding (no other
archive plugin needs special open-time options, so there is understandably no
infrastructure) as well as the UI standpoint (there is no dialog when opening
an archive via the main navigation, and adding one would be weird). I would
very much understand if an intrusive code change would not be acceptable just
for this problem.

Thus I would propose the following solution: Use auto detection of the encoding
(via KEncodingProber) per default (which should hopefully work for most people,
it worked at least on my zip file with Japanese encoding), but also have an
override via command line switch or environment variable that would force to
use an encoding for all opened zip files for the running Ark process. While not
ideal that would be good enough for me, and only require minimal changes and no
changes to the UI.

There is one risk though, in that using encoding auto detection could
potentially introduce regressions for other users. Note though that some kind
of encoding auto detection is already in use (see ZIP_FL_ENC_GUESS flag here:
https://libzip.org/documentation/zip_name_locate.html), but that is not working
sufficiently apparently.

Anyway, if my suggested approach is acceptable, I could prepare a patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to