https://bugs.kde.org/show_bug.cgi?id=409968
Dmitry Kazakov <dimul...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
Latest Commit| |https://invent.kde.org/kde/
| |krita/commit/b8870d02392a65
| |ee5b4607a3df8bf0f7da363f08
--- Comment #16 from Dmitry Kazakov <dimul...@gmail.com> ---
Git commit b8870d02392a65ee5b4607a3df8bf0f7da363f08 by Dmitry Kazakov.
Committed on 30/07/2019 at 14:16.
Pushed by dkazakov into branch 'master'.
Make KisShortcutMatcher be more tolerant to recursive entering
Some tools, e.g. text tool, may open a dialog right inside
beginPrimaryAction() callback. It may make KisShortcutMatcher crazy,
because all the modal dialogs have hey own event loop, therefore
the state machine of the shortcuts matcher will be broken.
This patch makes the matcher a bit more tolerant to such faults. It
just manually checks if it is entered more that once, and resets the
action in case a recursion is detected.
Related: bug 408826, bug 409275
M +168 -30 libs/ui/input/kis_shortcut_matcher.cpp
M +1 -0 libs/ui/input/kis_shortcut_matcher.h
https://invent.kde.org/kde/krita/commit/b8870d02392a65ee5b4607a3df8bf0f7da363f08
--- Comment #17 from Dmitry Kazakov <dimul...@gmail.com> ---
Git commit 008503fb5c5590cfe74c73c1e1a76b26a944e309 by Dmitry Kazakov.
Committed on 30/07/2019 at 14:16.
Pushed by dkazakov into branch 'master'.
Make shape painting tools unblocking (use strokes)
Opening a waiting dialog may make the shortcuts matcher unhappy,
so we should avoid that.
Related: bug 408826, bug 409275
M +3 -4 libs/ui/tool/kis_tool_shape.cc
M +1 -2 plugins/tools/basictools/kis_tool_ellipse.cc
M +42 -25 plugins/tools/basictools/kis_tool_gradient.cc
M +1 -3 plugins/tools/basictools/kis_tool_rectangle.cc
M +0 -2 plugins/tools/tool_polygon/kis_tool_polygon.cc
M +0 -3 plugins/tools/tool_polyline/kis_tool_polyline.cc
https://invent.kde.org/kde/krita/commit/008503fb5c5590cfe74c73c1e1a76b26a944e309
--
You are receiving this mail because:
You are watching all bug changes.
