https://bugs.kde.org/show_bug.cgi?id=410560
Nate Graham <n...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://commits.kde.org/eli
| |sa/40f5d8e31c208ee6d5652c20
| |97fa20f0fb3e5674
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
--- Comment #5 from Nate Graham <n...@kde.org> ---
Git commit 40f5d8e31c208ee6d5652c2097fa20f0fb3e5674 by Nate Graham.
Committed on 06/08/2019 at 02:43.
Pushed by ngraham into branch 'master'.
Always use white color for headerbar text
Summary:
Elisa uses the color scheme's highlighted text color for headerbar labels. This
is not
semantically correct since this color relies on being above the color scheme's
highlight
color to ensure adequate contrast. However the headerbar's blur does not do
this; rather,
it always produces a dark-ish color. This causes issues for color schemes where
the
highlight is light and the highlightext text color is dark, such as Materia
Light.
This patch fixes the problem by always using a hardcoded white color, which
always looks
good against the dark-ish blurry headerbar.
Test Plan:
Now looks good with the previously problematic Materia Light color scheme:
{F7166959}
Worst-case scenario for contrast with white album art; headerbar still darkens
it enough to make the text easily visible: {F7167007}
Reviewers: #vdg, #elisa, mgallien, astippich
Reviewed By: #elisa, mgallien
Differential Revision: https://phabricator.kde.org/D22949
M +16 -22 src/qml/HeaderBar.qml
https://commits.kde.org/elisa/40f5d8e31c208ee6d5652c2097fa20f0fb3e5674
--
You are receiving this mail because:
You are watching all bug changes.
