https://bugs.kde.org/show_bug.cgi?id=410744
Nate Graham <n...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
Latest Commit| |https://commits.kde.org/kde
| |plasma-addons/239f574c5b2fe
| |1367406f7ccecd31f491ce46a5e
--- Comment #7 from Nate Graham <n...@kde.org> ---
Git commit 239f574c5b2fe1367406f7ccecd31f491ce46a5e by Nate Graham, on behalf
of Ismael Asensio.
Committed on 10/08/2019 at 15:48.
Pushed by ngraham into branch 'Plasma/5.16'.
Fix #410744: Duplicate results when a 2nd unit is partially written in krunner
Summary:
When typing a conversion, and the second unit is partially written (i.e. "10€
to ru..." the results are duplicated by several times. This behavior happens
with different categories of units (lenght, currency, ...) and on different
languages.
The problem is that a new result is being added not once for every matching
unit, but once for every matching stringUnit, generating the duplicates.
Before:
{F7202568}
After:
{F7202571}
This is my first attempt to build kde from source and commit the diff to
phabricator, so please excuse any possible mistakes.
Test Plan:
Open krunner and type any conversion with a letter for the second unit: "10€ to
r"
Result for each matching second unit is only shown one time
Reviewers: ngraham, broulik
Reviewed By: ngraham, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D23064
M +4 -1 runners/converter/converterrunner.cpp
https://commits.kde.org/kdeplasma-addons/239f574c5b2fe1367406f7ccecd31f491ce46a5e
--
You are receiving this mail because:
You are watching all bug changes.
