https://bugs.kde.org/show_bug.cgi?id=401500

Nate Graham <n...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED
   Version Fixed In|                            |5.16.5
      Latest Commit|                            |https://commits.kde.org/pla
                   |                            |sma-workspace/cf931ee1b4033
                   |                            |dec9812bde1467e1329cd9d8628

--- Comment #3 from Nate Graham <n...@kde.org> ---
Git commit cf931ee1b4033dec9812bde1467e1329cd9d8628 by Nate Graham.
Committed on 29/08/2019 at 15:38.
Pushed by ngraham into branch 'master'.

[Notifications] Don't allow popup to obscure things in corners

Summary:
One thing that has been bugging me a bit with notifications is how close the
pop-up is
to the screen corners/edges. It's so close that it obscures various things that
live very
close to screen edges, such as windows' titlebars and the text input field in
chat apps.
The latter case is really annoying in particular because if you have multiple
chat apps
running, notifications from the app that's in the background will obscure what
you're
typing in the text input field of the foreground chat app.

This patch fixes these types of issues by doing the following:
- Adjusting the popup positioning algorithm make popups that are in a corner
equidistant from both adjacent screen edges, rather than only one
- Doubling the defualt distance from the nearest corner/edge

The combination of these changes allows pop-ups to no longer obscure window
titlebars
and chat windows' input fields.
FIXED-IN: 5.16.5

Test Plan:
Top corner popup position no longer obscures window titlebar text and buttons:
{F7259424}
Bottom corner popup position no longer obscures chat app's text input field:
{F7259425}

Reviewers: broulik, #plasma, #vdg

Reviewed By: broulik, #plasma

Subscribers: cblack, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D23253

M  +2    -2    applets/notifications/package/contents/ui/global/Globals.qml

https://commits.kde.org/plasma-workspace/cf931ee1b4033dec9812bde1467e1329cd9d8628

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to