https://bugs.kde.org/show_bug.cgi?id=411221
David Edmundson <k...@davidedmundson.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://commits.kde.org/pla
| |sma-framework/5f746ce1c2c2d
| |5a8c1be4f62347e18534d95e29d
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #4 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 5f746ce1c2c2d5a8c1be4f62347e18534d95e29d by David Edmundson.
Committed on 07/09/2019 at 21:19.
Pushed by davidedmundson into branch 'master'.
Fix crash on teardown with Applet's ConfigLoader
Summary:
Deleting AppletPrivate will delete the ConfigLoader which will cause a
save, which can trigger a configSaved signal.
I think it is correct that the config might emit a signal just before
closing, and not at fault.
AppletPrivate is deleted by this point, but Applet is not so the
connection is still alive.
When we handle the signal, it goes into a Q_PRIVATE_SLOT that crashes.
This disconnect pattern is already used for guarding self config
changes.
Test Plan: kquitapp5 plasmashell, no longer crashes
Reviewers: #plasma, alexeymin
Reviewed By: alexeymin
Subscribers: alexeymin, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D23707
M +4 -0 src/plasma/applet.cpp
https://commits.kde.org/plasma-framework/5f746ce1c2c2d5a8c1be4f62347e18534d95e29d
--
You are receiving this mail because:
You are watching all bug changes.
