https://bugs.kde.org/show_bug.cgi?id=412211

--- Comment #15 from Vlad Zahorodnii <vladz...@gmail.com> ---
Git commit c265c7f2c698ce51c039d3fe009fe09981ce1267 by Vlad Zahorodnii.
Committed on 26/09/2019 at 08:31.
Pushed by vladz into branch 'Plasma/5.17'.

[nightcolor] Use local time in Automatic and Location mode

Summary:
Currently Night Color doesn't handle time zones very well. For example,
if the user's time zone is UTC-8, then computed timings of sunrise and
sunset (in UTC) will be a bit gibberish as sunset occurs before sunrise
rather than vice versa.

This change switches relevant parts of Night Color to local time in
order to fix expectations about the order of morning and evening in
updateSunTimings() method as well to simplify the code a bit (dealing
with UTC and local time can be painful sometimes).

Reviewers: #kwin, romangg

Reviewed By: #kwin, romangg

Subscribers: romangg, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D24153

M  +25   -33   colorcorrection/manager.cpp
M  +1    -1    colorcorrection/manager.h
M  +25   -14   colorcorrection/suncalc.cpp
M  +1    -1    colorcorrection/suncalc.h

https://commits.kde.org/kwin/c265c7f2c698ce51c039d3fe009fe09981ce1267

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to