https://bugs.kde.org/show_bug.cgi?id=410341

Tymond <tamtamy.tym...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|tamtamy.tym...@gmail.com    |krita-bugs-n...@kde.org
             Status|ASSIGNED                    |CONFIRMED

--- Comment #1 from Tymond <tamtamy.tym...@gmail.com> ---
Related: bug 396669

It looks like metadata are kind of broken anyway. I could "fix this" by making
it behave independently, but... I can't test if it breaks anything, because
most of the code in metadata is either broken or wrong.

The reason why all those checkboxes behave as one is that they are all
distinguished as "exif:Flash" instead of "exif:Flash:Fired" etc. because
exif:Flash, differently from all other fields in exif: scheme, is a structure
(which means it contains other fields inside). The code looks like someone knew
about it, but later forgot or at least forgot to check it in practice.

The second/main reason is that all updates in one widget are propagated to all
other widgets using the name of the property as the only thing that
differentiate between what should get the notification and what shouldn't. All
checkboxes has a property called "checked", which is why when one changes its
"checked" status, they all change it too.

Looks like the main reason for all those trouble is not separating the model
and the view enough.

I'm gonna unassign myself now. This bug depends on untangling the metadata code
and fixing other bugs. It shouldn't be very difficult, but it will take some
time, especially because half of the information is in .ui files and schemes.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to