https://bugs.kde.org/show_bug.cgi?id=350861

David Edmundson <k...@davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |http://commits.kde.org/kinf
                   |                            |ocenter/95569a0eae884427c7f
                   |                            |7ab11fd63ae577f0be16d
         Resolution|DUPLICATE                   |FIXED

--- Comment #2 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 95569a0eae884427c7f7ab11fd63ae577f0be16d by David Edmundson.
Committed on 08/05/2016 at 12:56.
Pushed by davidedmundson into branch 'Plasma/5.6'.

Keep a reference to the Solid::Device whilst using it's interface

Otherwise we were effectively relying on Solid's cache for memory
management.

This led to a problem that QML's QObject wrapper would detect the
Solid::Battery was being deleted on shutdown, and re-evaluate
currentBattery. This would then call BatteryModel.fetch(0) which being
slightly behind would then return an invalid object, as well as doing
pointless processing during application shut down.

This ensure items get deleted in the correct order.
REVIEW: 127862

M  +13   -16   Modules/energy/batterymodel.cpp
M  +2    -1    Modules/energy/batterymodel.h

http://commits.kde.org/kinfocenter/95569a0eae884427c7f7ab11fd63ae577f0be16d

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to