https://bugs.kde.org/show_bug.cgi?id=413018
David Redondo <k...@david-redondo.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Version Fixed In| |5.17.1
Latest Commit| |https://commits.kde.org/pla
| |sma-workspace/a1cf305ffb21b
| |8ae8bbaf4d6ce03bbaa94cff405
Status|CONFIRMED |RESOLVED
--- Comment #28 from David Redondo <k...@david-redondo.de> ---
Git commit a1cf305ffb21b8ae8bbaf4d6ce03bbaa94cff405 by David Redondo.
Committed on 21/10/2019 at 08:51.
Pushed by davidre into branch 'Plasma/5.17'.
Fix slideshow crashing in invalidate()
Summary:
QSortFilterProxyModel uses std::stable_sort internally which requires that the
comparison function generates a strict weak ordering. Returning true or false
randomly didn't fullfil this requirement causing a crash in some calls to
invalidate.
To keep the random order consistent a vector of row indices is used which
records
the current random order.
FIXED-IN: 5.17.1
Test Plan:
To reproduce the bug use a slideshow in random order with few pictures and a
small
time intervall.
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: davidedmundson, broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24723
M +1 -1 wallpapers/image/image.cpp
M +55 -4 wallpapers/image/slidefiltermodel.cpp
M +6 -1 wallpapers/image/slidefiltermodel.h
https://commits.kde.org/plasma-workspace/a1cf305ffb21b8ae8bbaf4d6ce03bbaa94cff405
--
You are receiving this mail because:
You are watching all bug changes.
