https://bugs.kde.org/show_bug.cgi?id=414003

David Edmundson <k...@davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/kir
                   |                            |igami/4a9820a6df15a55a7d36d
                   |                            |343ce70a25ba7d56b79

--- Comment #17 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 4a9820a6df15a55a7d36d343ce70a25ba7d56b79 by David Edmundson.
Committed on 13/11/2019 at 18:09.
Pushed by davidedmundson into branch 'master'.

Make QmlComponentsPool one instance per engine

Summary:
If we create 2 engines in an application the singleton is initialised to
the first engine. If that first engine disappears the internal m_unit is
dangling.

A good example of this is systemsettings in the icon view if we enter
two modules one after another. It's currently only kept alive because
the sidebar created the first reference.

Test Plan:
System settings in icon view
opened global theme
went back
open fonts theme
didn't crash

Subscribers: plasma-devel

Tags: #kirigami

Differential Revision: https://phabricator.kde.org/D25284

M  +33   -21   src/columnview.cpp
M  +1    -3    src/columnview_p.h

https://commits.kde.org/kirigami/4a9820a6df15a55a7d36d343ce70a25ba7d56b79

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to