https://bugs.kde.org/show_bug.cgi?id=412737
Méven Car <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CONFIRMED |RESOLVED Version Fixed In| |5.65 Resolution|--- |FIXED Latest Commit| |https://commits.kde.org/kio | |/816fc6f9444fe70cdddc67b94e | |8027fdaab99c20 --- Comment #11 from Méven Car <[email protected]> --- Git commit 816fc6f9444fe70cdddc67b94e8027fdaab99c20 by Méven Car. Committed on 04/12/2019 at 10:21. Pushed by meven into branch 'master'. [KFileWidget] Avoid calling slotOk right after the url changed Summary: When _k_slotViewKeyEnterReturnPressed is called, KDirOperator::_k_slotActivated is called first potentially opening another directory. And since the directory changed, the kdiroperator selection is empty, causing then kiowidgets-kdirmodeltest to call slotOk and if a filename was present in the filename field, it will cause the dialog to accept() prematurely. This patch prevents KDirOperator::keyEnterReturnPressed to be emitted when QAbstractItemView::activated would be, preventing the issue in the first place. FIXED-IN: 5.65 Relates to D19824 Test Plan: 1. Save a file using KFileWidget 2. Go to a folder with files and directories 3. Select a file 4. Select a directory 5. Hit Enter Before: The directory is opened briefly and the dialog returns. After: The selected directory is opened. Reviewers: #frameworks, ngraham, elvisangelaccio, dfaure Reviewed By: ngraham, dfaure Subscribers: ahmadsamir, feverfew, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D25420 M +13 -10 src/filewidgets/kdiroperator.cpp M +0 -2 src/filewidgets/kdiroperator.h https://commits.kde.org/kio/816fc6f9444fe70cdddc67b94e8027fdaab99c20 -- You are receiving this mail because: You are watching all bug changes.
