https://bugs.kde.org/show_bug.cgi?id=411166
David Edmundson <k...@davidedmundson.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
Latest Commit| |https://commits.kde.org/kwi
| |n/1a13015d2d1de3ffb94501434
| |80e729057992c45
--- Comment #21 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 1a13015d2d1de3ffb9450143480e729057992c45 by David Edmundson.
Committed on 14/12/2019 at 15:08.
Pushed by davidedmundson into branch 'Plasma/5.17'.
Possible fix for KDecoration crash in systemsettings
Summary:
I could never reproduce the crash, but we know from gdb that it's from
the decorationSettings object
We are setting the same QObject instance as a context property in
multiple contexts at once. This is already slightly odd especially from the POV
of
Qt's internal property cache.
Given we want one object to be exposed to all contexts, we can expose it
to the parent context only once and achieve the same result in a simpler
way.
Test Plan:
Verified opening and closing system settings still worked for me.
I could never reproduce the original crash.
Reviewers: #kwin, ngraham
Reviewed By: ngraham
Subscribers: ngraham, apol, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D25913
M +1 -1 plugins/kdecorations/aurorae/src/aurorae.cpp
https://commits.kde.org/kwin/1a13015d2d1de3ffb9450143480e729057992c45
--
You are receiving this mail because:
You are watching all bug changes.
