https://bugs.kde.org/show_bug.cgi?id=400418

--- Comment #5 from Vlad Zahorodnii <vladz...@gmail.com> ---
Git commit 5bec89ac90d5c9d72b03b60cf62bb6ef9ffb0808 by Vlad Zahorodnii.
Committed on 07/01/2020 at 15:12.
Pushed by vladz into branch 'master'.

[nightcolor] Introduce inhibition API

Summary:
The new API allows to block Night Color temporarily. This can be useful
for applications such as video games and plasma applets.

Test Plan: Called inhibit() and uninhibit() from D-Feet.

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D25786

M  +77   -0    colorcorrection/colorcorrectdbusinterface.cpp
M  +22   -1    colorcorrection/colorcorrectdbusinterface.h
M  +46   -33   colorcorrection/manager.cpp
M  +30   -0    colorcorrection/manager.h
M  +34   -0    org.kde.kwin.ColorCorrect.xml

https://commits.kde.org/kwin/5bec89ac90d5c9d72b03b60cf62bb6ef9ffb0808

--- Comment #6 from Vlad Zahorodnii <vladz...@gmail.com> ---
Git commit 33f46f6d6c10ae6fcedad51f932d34907bb6e749 by Vlad Zahorodnii.
Committed on 07/01/2020 at 15:12.
Pushed by vladz into branch 'master'.

[nightcolor] Expose some properties to d-bus

Summary:
Currently, in order to retrieve the current screen color temperature
applied to all screen as well other attributes of night color manager,
one has to call nightColorInfo() periodically. This goes against well
established patterns in d-bus world. It is recommended to expose a
bunch of d-bus properties rather than have a method that returns all
relevant properties stored in a JSON object.

The ugliest thing about this patch is that a lot of code is duplicated
to emit the PropertiesChanged signal. Unfortunately, QtDBus doesn't
take care of this and we are left with only two options - either do
weird things with QMetaObject or manually emit the signal. I have
picked the second option since it's more comprehensible and less magic
is going on, but I have to admit that the chosen approach is ugly.

I hope that "Qt 6 will fix it."

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D25946

M  +125  -1    colorcorrection/colorcorrectdbusinterface.cpp
M  +12   -0    colorcorrection/colorcorrectdbusinterface.h
M  +97   -14   colorcorrection/manager.cpp
M  +62   -0    colorcorrection/manager.h
M  +32   -0    org.kde.kwin.ColorCorrect.xml

https://commits.kde.org/kwin/33f46f6d6c10ae6fcedad51f932d34907bb6e749

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to