https://bugs.kde.org/show_bug.cgi?id=415625
Boudewijn Rempt <b...@valdyas.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit|https://invent.kde.org/kde/ |https://invent.kde.org/kde/
|krita/commit/f88c8b3529816b |krita/commit/4aab942697147c
|e7f2be60528955e83483a22a1b |1e3496fa7d4d16e5dd1a8fe99c
|https://invent.kde.org/kde/ |https://invent.kde.org/kde/
|krita/commit/4aab942697147c |krita/commit/f88c8b3529816b
|1e3496fa7d4d16e5dd1a8fe99c |e7f2be60528955e83483a22a1b
--- Comment #8 from Boudewijn Rempt <b...@valdyas.org> ---
Git commit 4aab942697147c1e3496fa7d4d16e5dd1a8fe99c by Boudewijn Rempt, on
behalf of Dmitry Kazakov.
Committed on 28/01/2020 at 09:09.
Pushed by rempt into branch 'krita/4.2'.
Fix assert when the stroke is cancelled in endStrokeCallback()
The patch basically deprecates cancelStrokeId() functionality, which
is now replaced with MutatedStrokeJobsInterface.
We can add new jobs via normal addJob() interface only before the stroke
is finished. After finishing, only addMutatedJob() is available.
(cherry picked from commit f88c8b3529816be7f2be60528955e83483a22a1b)
M +0 -5 libs/image/commands_new/kis_saved_commands.cpp
M +0 -2 libs/image/commands_new/kis_saved_commands.h
M +1 -1 libs/image/kis_stroke.cpp
M +0 -15 libs/image/kis_stroke_strategy.h
M +4 -1 libs/image/kis_stroke_strategy_undo_command_based.cpp
M +0 -4 libs/image/kis_strokes_queue.cpp
https://invent.kde.org/kde/krita/commit/4aab942697147c1e3496fa7d4d16e5dd1a8fe99c
--- Comment #9 from Boudewijn Rempt <b...@valdyas.org> ---
Git commit 4ec9beafc1d40205b82aa50dc6f981cc10891d0f by Boudewijn Rempt, on
behalf of Agata Cacko.
Committed on 28/01/2020 at 09:09.
Pushed by rempt into branch 'krita/4.2'.
Initialize transform tool args when ending stroke
Before this commit, transform tool would get an
assert when switching to another tool without
any changes.
This commit removes trying to cancel the stroke
in the finishStrokeCallback() call
and initializes m_savedTransformArgs so the finishing
can happen as always.
WARNING: it probably isn't the "proper" solution
for this issue. It does work correctly, but it adds
an unnecessary undo step in the situation when cancelling
should be used instead of finishing the stroke
(for example when the user switches to transform tool
and then immediately to another tool without making any changes).
Related: bug 414672
(cherry picked from commit 8ef04427c4b8e63265ab4bb3456659cf4b0d39a4)
M +25 -0
plugins/tools/tool_transform2/strokes/transform_stroke_strategy.cpp
https://invent.kde.org/kde/krita/commit/4ec9beafc1d40205b82aa50dc6f981cc10891d0f
--
You are receiving this mail because:
You are watching all bug changes.
