https://bugs.kde.org/show_bug.cgi?id=327295
Harald Sitter <sit...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/kio
| |-extras/a5f51238fab75c407c5
| |3dd6ec348937c08b6022d
Version Fixed In| |19.12.3
Status|CONFIRMED |RESOLVED
--- Comment #7 from Harald Sitter <sit...@kde.org> ---
Git commit a5f51238fab75c407c53dd6ec348937c08b6022d by Harald Sitter.
Committed on 13/02/2020 at 11:19.
Pushed by sitter into branch 'master'.
smb: install smb as both smb:// and cifs://
Summary:
the latter while not IANA registered is apparently used in places. to
cheaply support it we now configure the protocol file for both protocol
'smb' and 'cifs' and installing two protocol files. they are still both
backed by the same plugin and otherwise the same.
code-wise this also required adjustments to the URL validation tech as
it has hardcoded checks for smb schemes.
FIXED-IN: 19.12.3
Test Plan:
- cifs://host/share
- cifs://host
- cifs://
all open correctly. they do get translated to smb because of the checkUrl code.
checkUrl seems entirely pointless, SMBUrl does a bit of validation/fixing as
part of
updateCache. It occurs to me checkUrl should simply be incorporated into SMBUrl
and we should construct an SMBUrl where we previously called checkUrl. before
doing
anything of value we construct SMBUrls anyway, so the isolated logic does
absolutely
nothing SMBUrl couldn't do just as well. also needs a unit test -.- ... too
much
refactoring for a bugfix though
Reviewers: dfaure, ngraham
Reviewed By: ngraham
Subscribers: meven, feverfew, kde-frameworks-devel, kfm-devel
Tags: #dolphin, #frameworks
Differential Revision: https://phabricator.kde.org/D27291
M +4 -1 smb/CMakeLists.txt
M +17 -3 smb/kio_smb_browse.cpp
M +8 -0 smb/kio_smb_internal.cpp
R +1 -1 smb/smb.protocol.cmake [from: smb/smb.protocol - 093%
similarity]
https://commits.kde.org/kio-extras/a5f51238fab75c407c53dd6ec348937c08b6022d
--
You are receiving this mail because:
You are watching all bug changes.
