https://bugs.kde.org/show_bug.cgi?id=205954
Ahmad Samir <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Latest Commit| |https://commits.kde.org/kio | |/a2335335ecfe4b211a2898594a | |21d52c79107b7a Status|CONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #4 from Ahmad Samir <[email protected]> --- Git commit a2335335ecfe4b211a2898594a21d52c79107b7a by Ahmad Samir. Committed on 11/04/2020 at 09:33. Pushed by ahmadsamir into branch 'master'. [KPropertiesDialog] Disable changing remote dir icons Summary: Changing the icon of a dir on e.g. a samba share doesn't seem to have an effect, this is intentional as reading .directory would impact network resources negatively, see the bug report for more details. Change the code to only show the KIconButton only for local dirs and desktop:/. Test Plan: make && ctest And testing an sftp://, the button to change the icon isn't shown Reviewers: #frameworks, dfaure, sitter Reviewed By: dfaure Subscribers: kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D28679 M +6 -3 src/widgets/kpropertiesdialog.cpp https://commits.kde.org/kio/a2335335ecfe4b211a2898594a21d52c79107b7a -- You are receiving this mail because: You are watching all bug changes.
