https://bugs.kde.org/show_bug.cgi?id=195828

Igor Poboiko <igor.pobo...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REPORTED                    |RESOLVED
      Latest Commit|                            |https://commits.kde.org/kte
                   |                            |xtwidgets/0e14353610fa7f121
                   |                            |659fbe28dd764b6c2d6dc77
         Resolution|---                         |FIXED

--- Comment #5 from Igor Poboiko <igor.pobo...@gmail.com> ---
Git commit 0e14353610fa7f121659fbe28dd764b6c2d6dc77 by Igor Poboiko.
Committed on 19/04/2020 at 09:23.
Pushed by poboiko into branch 'master'.

[KRichTextEdit] Fix scroll jumping around when horizontal rule is added

Summary:
Due to Qt bug 83605, it's not a good idea to `setTextCursor` while the cursor
is inside `beginEditBlock / endEditBlock` (scrollbar might jump to the top),
see KDE bug 195828. It's sufficient to move `setTextCursor` outside to fix it.
(it's never too late... :)

This patch also adds a test for this case (which currently fails due to
regression, see {D28819} and {D28964} for the fix).

Test Plan:
 1) Apply {D28964}
 2) `ctest`

Reviewers: #frameworks, dfaure

Reviewed By: dfaure

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D28966

M  +19   -0    autotests/krichtextedittest.cpp
M  +1    -0    autotests/krichtextedittest.h
M  +1    -1    src/widgets/krichtextedit.cpp

https://commits.kde.org/ktextwidgets/0e14353610fa7f121659fbe28dd764b6c2d6dc77

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to