https://bugs.kde.org/show_bug.cgi?id=361097
Anthony <bvb...@abv.bg> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |bvb...@abv.bg
--- Comment #30 from Anthony <bvb...@abv.bg> ---
Patch looks good, but when you write qml keep in your mind it is different from
C++. You can make
visible: targetItem != null
setted targetItem to null will set automatically visible to false :) So it's
not needed to initialize properties to -1, just add exactly what you want like
a logic and it will work
property int maxHeight: theme.mSize(theme.defaultFont).height *
(plasmoid.configuration.textLines + 1)
Do not set width and hieght to 60 and do not get difference between
Qt.ScrollBarAlwaysOn - Qt.ScrollBarAlwaysOff, this is make it by Qt. So patch
can be twice a small and more compact. You can add to review here ->
https://git.reviewboard.kde.org/r/
--
You are receiving this mail because:
You are watching all bug changes.
