https://bugs.kde.org/show_bug.cgi?id=418443

Ahmad Samir <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/kio
                   |                            |/1cac602d9966f82a2e85440d74
                   |                            |d9cc3ad014a1aa
   Version Fixed In|                            |5.71
             Status|CONFIRMED                   |RESOLVED

--- Comment #4 from Ahmad Samir <[email protected]> ---
Git commit 1cac602d9966f82a2e85440d74d9cc3ad014a1aa by Ahmad Samir.
Committed on 09/05/2020 at 10:55.
Pushed by ahmadsamir into branch 'master'.

[CopyJob] Check free space for remote urls before copying and other
improvements

Summary:
Use KIO::FileSystemFreeSpaceJob to check free space for remote urls.

Thanks to sitter for pin-pointing the responsible code in the bug report,
and to kbroulik for pointing out the existence of KIO::FileSystemFreeSpaceJob.

Also use UDSEntry to check writability for both local and remote urls.

FIXED-IN: 5.71

Test Plan:
testtrash unit test fails (again...)

- Find/create a local partition with a small capacity, copying a file/dir
  that is bigger than the partition will show the error message as before
- Do the same for a remote url (I tested with sftp://), an error message
  about not having enough free space is shown

Reviewers: #frameworks, dfaure, meven, sitter

Reviewed By: dfaure

Subscribers: ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D29485

M  +51   -35   src/core/copyjob.cpp

https://commits.kde.org/kio/1cac602d9966f82a2e85440d74d9cc3ad014a1aa

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to